Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If an export has been pending for more than 6 hours mark as failed #1068

Closed
pld opened this issue Jul 20, 2017 · 1 comment
Closed

If an export has been pending for more than 6 hours mark as failed #1068

pld opened this issue Jul 20, 2017 · 1 comment
Assignees
@moshthepitt
Labels
Has-PR Module: Exports Priority: Medium Support
Milestone
Week 32 - 33

Comments

@pld
Copy link
Member

pld commented Jul 20, 2017 •
edited by imkingrobi
Loading

I'm fine with adjusting 6 hours, but we have some exports in the pending state for months, after a hard max pending cut-off time we should stop the celery process and mark long exports as failed.

Aha! Link: https://ona.aha.io/features/PROD-544
@pld pld added this to the Q3 High Priority milestone Jul 20, 2017
@pld pld changed the title If an export has been pending for more than 6 hours it probably failed If an export has been pending for more than 6 hours mark as failed Jul 20, 2017
@ukanga
Copy link
Member

ukanga commented Aug 4, 2017

Also apply to failed exports.

@ukanga ukanga modified the milestones: Week 32 - 33, Q3 High Priority Aug 4, 2017
moshthepitt added a commit that referenced this issue Aug 9, 2017
@moshthepitt
Deal with old exports
bbc348c 
Fixes: #1068

Create periodic tasks which:

- Find old pending exports and mark them as failed.

- Find old failed exports and delete them

The 'oldness' is determined by a configurable setting.
@moshthepitt moshthepitt mentioned this issue Aug 9, 2017
Merged
ukanga pushed a commit that referenced this issue Aug 11, 2017
@moshthepitt @ukanga
Cancel or delete stale pending and/or failed exports
c1c7fca 
Create periodic tasks which:
- Find stale pending exports and mark them as failed.
- Find stale failed exports and delete them

An export is stale if it is older than `EXPORT_TASK_LIFESPAN` setting which has the default value of 6 hours.

Fixes: #1068
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moshthepitt moshthepitt

Labels
Has-PR Module: Exports Priority: Medium Support
Projects
None yet
Milestone
Week 32 - 33
Development

No branches or pull requests
3 participants
@pld @ukanga @moshthepitt