Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export permission to allow delete #1056

Merged
merged 7 commits into from
Jun 19, 2017

Conversation

ivermac
Copy link
Contributor

@ivermac ivermac commented Jun 16, 2017

No description provided.

@ivermac ivermac requested a review from ukanga June 16, 2017 14:40
Copy link
Member

@ukanga ukanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think other than naming looks good.

@@ -57,6 +57,30 @@ class ViewDjangoObjectPermissions(DjangoObjectPermissions):
}


class ExportDjangoPermission(IsAuthenticated,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename this to ExportDjangoObjectPermission to be consistent with the others.

@ukanga ukanga merged commit 6d9f681 into master Jun 19, 2017
@ukanga ukanga deleted the add-export-permission-to-allow-delete branch June 19, 2017 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants