Proper submission count on CSV imports #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pld
approved these changes
Jul 23, 2017
onadata/libs/utils/csv_import.py
Outdated
| pass | ||
| if additions % getattr(settings, | ||
| 'EXPORT_TASK_PROGRESS_UPDATE_BATCH', | ||
| 100) == 0: |
There was a problem hiding this comment.
Is there no default? 100 is a magic number
There was a problem hiding this comment.
Noted, will set a static variable for this.
| clean_and_parse_xml, | ||
| get_uuid_from_xml, | ||
| get_deprecated_uuid_from_xml, | ||
| get_submission_date_from_xml) |
There was a problem hiding this comment.
I actually prefer this style, but either consistently is fine, would be nice to define this in the style checker
There was a problem hiding this comment.
This is the work of yapf, I will add a config for it.
There was a problem hiding this comment.
Using the default pep8 style I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1065