Attachments count fix #1214
Merged
Attachments count fix #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ukanga
commented
Jan 22, 2018
ukanga
commented
- Fix media_all_received=False when media received is greater than media expected #1210 by using a distinct count of distinct media names without necessarily selecting greater than count.
- Fix Look into how media counts on instance objects are handled #1211
Uses distinct name to get correct count for media files received while still allowing duplicate files to be saved.
Refactor update_attachment_tracking to use the Instance.attachments_count property.
ukanga
force-pushed
the
attachments-count-fix
branch
from
153fbe6 to
c288ae8
Compare
moshthepitt
approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.