KJ | JW: Test That SAV Exports With Duplicate Column Names Fail #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test to ascertain that SAV exports fail when the form has duplicate column names.
|
Fix: #1226 This is because we catch exceptions for all failed SAV exports. The addition in this PR of reporting the exception means we can get the reason why individual SAV exports failed. |
- Edit export_builder to allow creation of SAV files with duplicate columns names. - Edit test to ascertain that this happens and the expected columns are created. - Move test from test_tasks file to test_export_builder.
ukanga
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test to ascertain that SAV exports fail when the form has duplicate column names.
Fix: #1216