Handle connection error on async exports #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pld
reviewed
Feb 7, 2018
onadata/apps/viewer/tasks.py
Outdated
| try: | ||
| result = export_types[export_type].apply_async((), kwargs=options) | ||
| except librabbitmq.ConnectionError as e: | ||
| export.delete() |
There was a problem hiding this comment.
why do we delete the export? could you add a comment
There was a problem hiding this comment.
The export did not start, I consider this failure as the export service being down but not a failure related to the data being exported. I think it is important we log the failure but it's not necessary to maintain the record. @moshthepitt seems it's important to have the record, I am going to remove the delete.
moshthepitt
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.