Add the default authentication classes to the Export viewset #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
force-pushed
the
add-authorization-methods-for-exports
branch
2 times, most recently
from
8a2dbe4 to
9d3cece
Compare
DavisRayM
force-pushed
the
add-authorization-methods-for-exports
branch
from
9d3cece to
c717b48
Compare
|
@DavisRayM Is there a reason this is still open? |
No, there is no reason. I think this was just forgotten for a bit, let me rebase and re-request review |
DavisRayM
force-pushed
the
add-authorization-methods-for-exports
branch
from
c717b48 to
9da0834
Compare
denniswambua
approved these changes
May 20, 2021
DavisRayM
added a commit
to onaio/duva
that referenced
this pull request
Jul 1, 2021
The `temp_token` variable is no longer necessary in OnaData v2.5.6+ as the Export viewset has been updated to support all API authentication schemes. More info [here](onaio/onadata#2023)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
N/A
Closes #2024