Default response format to JSON #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniswambua
previously approved these changes
Nov 24, 2021
DavisRayM
force-pushed
the
charts-lacking-format-issue
branch
from
31bad98 to
fc67b7c
Compare
| @@ -160,6 +161,7 @@ def test_get_on_categorized_field(self): | |||
| self.assertEqual(response.data['data'][0]['gender'], 'Male') | |||
| self.assertEqual(response.data['data'][1]['gender'], 'Female') | |||
|
|
|||
| @skip("https://github.com/onaio/onadata/pull/2170") | |||
There was a problem hiding this comment.
@DavisRayM Not sure why we are skipping this
There was a problem hiding this comment.
Skipping it because we default to JSON instead of returning a bad request with these changes.
There was a problem hiding this comment.
Can we just remove or edit that test?
There was a problem hiding this comment.
I can remove it, it's a bit similar to one of the other tests so I wasn't so sure about editing it. Let me remove it and re-request review
- Skip `test_return_bad_request_on_non_json_request_with_field_name` test
DavisRayM
force-pushed
the
charts-lacking-format-issue
branch
from
6268be7 to
b6990f8
Compare
denniswambua
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
JSONif not format is passedSteps taken to verify this change does what is intended
Side effects of implementing this change
The charts endpoint will always return a JSON response if the
formatquery param is emptyBefore submitting this PR for review, please make sure you have:
Related to #2151
Main reason for the update is because the browser would still return a
Not supportederror with the changes introduced in #2151; Which wasn't the ideal scenario for an API.... If the format is not specified we should always default to JSON IMO