Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue when trying to access azure attachments with the suffix query param #2291

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

DavisRayM
Copy link
Contributor

Changes / Features implemented

  • Move generate_attachments_download_url to libs/image_tools.py
  • Add generate_media_url_with_sas function
  • Update generate_attachments_download_url

Steps taken to verify this change does what is intended

  • QA

Side effects of implementing this change

N/A

Before submitting this PR for review, please make sure you have:

Closes #

@DavisRayM DavisRayM requested review from KipSigei and ukanga July 13, 2022 09:56
@DavisRayM DavisRayM force-pushed the image-issue-azure branch from 41761ae to 2ffeb18 Compare July 13, 2022 09:59
@DavisRayM DavisRayM enabled auto-merge July 13, 2022 13:10
@DavisRayM DavisRayM merged commit 2c9a8eb into main Jul 13, 2022
@DavisRayM DavisRayM deleted the image-issue-azure branch July 13, 2022 13:12
@DavisRayM DavisRayM mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants