User per-role cache key for the organization_profile_viewset #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, invalidate cache when user x organization permissions are updated Co-authored-by: Kelvin Muchiri <[email protected]>
FrankApiyo
force-pushed
the
use-per-role-cache-key-for-organization-profile
branch
from
b062185 to
cebcded
Compare
FrankApiyo
changed the title
onadata/apps/api/tasks.py
Outdated
| @@ -36,6 +38,14 @@ | |||
| User = get_user_model() | |||
|
|
|||
|
|
|||
| def invalidate_organization_cache(org_username): | |||
There was a problem hiding this comment.
Can we move this to logger_tools?
There was a problem hiding this comment.
I've moved it to cache_tools instead
| cache.set(f"{ORG_PROFILE_CACHE}{username}{request.user.username}", organization) | ||
| organization_profile = OrganizationProfile.objects.get(user__username=username) | ||
| cache_key = get_cache_key(request.user, organization_profile) | ||
| cache.set(cache_key, organization) |
There was a problem hiding this comment.
Should we use set_cache_for_org here?
There was a problem hiding this comment.
@FrankApiyo I've just realized set_cache_for_org is in test_tasks and not in this file
| return Response(data=serializer.errors, status=status.HTTP_400_BAD_REQUEST) | ||
|
|
||
| serializer.save() | ||
|
|
||
| data = OrganizationSerializer( |
There was a problem hiding this comment.
We should use instead self.get_serializer_class
FrankApiyo
force-pushed
the
use-per-role-cache-key-for-organization-profile
branch
from
09b94e3 to
332b9c0
Compare
FrankApiyo
force-pushed
the
use-per-role-cache-key-for-organization-profile
branch
from
332b9c0 to
ba44d71
Compare
ukanga
approved these changes
Aug 21, 2024
kelvin-muchiri
approved these changes
Aug 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
N/A
Before submitting this PR for review, please make sure you have:
Closes #2672