Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument of type 'ProjectUserObjectPermission' is not iterable #2682

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Fix argument of type 'ProjectUserObjectPermission' is not iterable #2682

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af86f3c
fix argument of type 'ProjectUserObjectPermission' is not iterable
kelvin-muchiri Aug 26, 2024
2b10d77
rename symbol
kelvin-muchiri Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions onadata/apps/logger/migrations/0023_populate_project_entity_list_perm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,19 @@ def add_project_entitylist_perm(apps, schema_editor):
"""Assign `add_project_entitylist` permission to existing Owners, Managers"""
Project = apps.get_model("logger", "Project")
content_type = ContentType.objects.get_for_model(Project)
perm = "add_project_entitylist"
perm_str = "add_project_entitylist"

with use_master:
_, created = Permission.objects.get_or_create(
codename=perm,
codename=perm_str,
content_type=content_type,
defaults={
"name": "Can add entitylist to project",
},
)

if created:
print(f"Permission {perm} created because it does not exist")
print(f"Permission {perm_str} created because it does not exist")

project_qs = Project.objects.filter(deleted_at__isnull=True)
eta = project_qs.count()
Expand All @@ -42,13 +42,13 @@ def add_project_entitylist_perm(apps, schema_editor):
permission__codename="add_project"
)

for perm in project_user_obj_perm_qs.iterator(chunk_size=100):
user = User.objects.get(id=perm.user_id)
assign_perm(perm, user, project)
for user_obj_perm in project_user_obj_perm_qs.iterator(chunk_size=100):
user = User.objects.get(id=user_obj_perm.user_id)
assign_perm(perm_str, user, project)

for perm in project_group_obj_perm_qs.iterator(chunk_size=100):
group = Group.objects.get(id=perm.group_id)
assign_perm(perm, group, project)
for group_obj_perm in project_group_obj_perm_qs.iterator(chunk_size=100):
group = Group.objects.get(id=group_obj_perm.group_id)
assign_perm(perm_str, group, project)

eta -= 1
print("eta", eta)
Expand Down
Loading