Remove deleted_by serializer field for Dataviews #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankApiyo
changed the title
FrankApiyo
requested review from
ukanga,
faith-mutua,
kelvin-muchiri and
ciremusyoka
ukanga
reviewed
Oct 18, 2024
There was a problem hiding this comment.
@FrankApiyo Why do we need the deleted_by field yet we do not expose to the user deleted records?
Could we exclude this field instead?
FrankApiyo
force-pushed
the
fix-2720
branch
2 times, most recently
from
570e254 to
a3b56ee
Compare
| Remove deleted DataViews | ||
| """ | ||
| return super().filter_queryset( | ||
| queryset.filter(deleted_at=None, deleted_by=None) |
There was a problem hiding this comment.
@FrankApiyo Why do we need to filter by both, why not just use deleted_at?
ukanga
reviewed
Oct 22, 2024
Update lookup field
Remove redundant test case
Remove filter_queryset method
kelvin-muchiri
approved these changes
Oct 23, 2024
Merged
kelvin-muchiri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
deleted_byserializer fieldSteps taken to verify this change does what is intended
Ran locally
Side effects of implementing this change
N/A
Before submitting this PR for review, please make sure you have:
Closes #2720