fix: value error exception for non numeric project id #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try: | ||
| request, __ = get_request_and_username(self.context) | ||
| except ValueError as exc: | ||
| raise serializers.ValidationError(str(exc)) |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 2 months ago
To fix the problem, we should avoid exposing the detailed exception message to the end user. Instead, we should log the detailed error message on the server and return a generic error message to the user. This can be achieved by using Python's logging module to log the exception details and raising a serializers.ValidationError with a generic message.
Suggested changeset
1
onadata/libs/serializers/data_serializer.py
| @@ -311,3 +311,6 @@ | ||
| except ValueError as exc: | ||
| raise serializers.ValidationError(str(exc)) | ||
| import logging | ||
| logger = logging.getLogger(__name__) | ||
| logger.error("Error in getting request and username", exc_info=True) | ||
| raise serializers.ValidationError(_("An internal error has occurred. Please try again later.")) | ||
| if not request.FILES or "xml_submission_file" not in request.FILES: |
Copilot is powered by AI and may make mistakes. Always verify output.
FrankApiyo
approved these changes
Nov 25, 2024
kelvin-muchiri
approved these changes
Nov 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Validates project ID and form ID are numeric when handling submissions.
Steps taken to verify this change does what is intended
Try post a submission to /projects/not_numeric/submission.
Side effects of implementing this change
N/A
Before submitting this PR for review, please make sure you have:
Closes #2719