-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easy install. #886
Easy install. #886
Conversation
Signed-off-by: Njagi Mwaniki <[email protected]>
Signed-off-by: Njagi Mwaniki <[email protected]>
Signed-off-by: Njagi Mwaniki <[email protected]>
7214d18
to
068f527
Compare
@echo "Downloading ona core dependencies and running migrations for you (hopefully into a virtualenv)... \n (This will take a while, go grab a coffee or something.)\n\n" | ||
python2 -m pip install -r requirements/base.pip | ||
python2 -m pip install -r requirements/dev.pip | ||
# what does syncdb do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like nothing anymore, https://stackoverflow.com/questions/29683494/what-should-i-use-instead-of-syncdb-in-django-1-9. I think it's fine to remove these 2 lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL how do I forget to remove these comments that I add as I read code 😁
@@ -1,4 +1,4 @@ | |||
# Ubuntu installation instructions | |||
# Installation instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you should change the title, that ubuntu script is still just for ubuntu, https://github.com/onaio/onadata/blob/master/script/install/ubuntu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, better probably, have a new sub section below this so
# Installation instructions
## Database Setup
### Using Ubuntu
[lines 3-12 without line 5]
### Using docker
[lines 15-42]
remove line 14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I totally agree, however I am thinking of something like.
In base OS
In Docker
Since Docker will be using ubuntu base image in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can do that and mention on the line with the ubuntu install script that this line is only for ubuntu, otherwise we assume you've installed postgres already, that script is the only reason to keep ubuntu in the title
@@ -1,4 +1,4 @@ | |||
# Ubuntu installation instructions | |||
# Installation instructions. | |||
## Prepare Os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be OS
in caps
@@ -11,6 +11,36 @@ Replace username and db name accordingly. | |||
sudo su postgres -c "psql -d onadata -c \"CREATE EXTENSION IF NOT EXISTS postgis;\"" | |||
sudo su postgres -c "psql -d onadata -c \"CREATE EXTENSION IF NOT EXISTS postgis_topology;\"" | |||
|
|||
**Alternatively** you can use docker to set up the DB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove alternatively and make this a section ### Using docker
Signed-off-by: Njagi Mwaniki <[email protected]>
Signed-off-by: Njagi Mwaniki <[email protected]>
- Fix typo `postgres` to `onadata` - Change `connect` in psql to `CONNECT` Signed-off-by: Njagi Mwaniki <[email protected]>
c3a90a1
to
3bcfea3
Compare
Make running onadata easier.
Depends onaio/docker-builds#12