catch the assert error #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pld
requested changes
Jan 24, 2017
| try: | ||
| item = get_ordered_repeat_value(key, item) | ||
| except AssertionError: | ||
| pass |
There was a problem hiding this comment.
why bother throwing the assert error if we're not going to do anything?
There was a problem hiding this comment.
I am not sure why it was added. I am removing it and test if breaks something
denniswambua
force-pushed
the
1330-csv-export-fix
branch
from
777ea4b to
9f56d83
Compare
Signed-off-by: Dennis Wambua <[email protected]>
Signed-off-by: Dennis Wambua <[email protected]>
denniswambua
force-pushed
the
1330-csv-export-fix
branch
from
9f56d83 to
425a8f2
Compare
|
@pld assert error removed |
pld
approved these changes
Jan 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes csv export errors
Signed-off-by: Dennis Wambua [email protected]