-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant new users formbuilder perms #893
Conversation
I can't seem to find a better way to test a |
@ivermac on stage, after creating a new acc, the error is still there |
@ivermac @denniswambua It works now for new users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testable?
See the second comment on the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivermac you test using urlmatch
Example https://github.com/onaio/onadata/blob/master/onadata/apps/api/tests/viewsets/test_xform_viewset.py#L90
I think what should be tested is whether the signal function was called or not. |
@ivermac sounds good, please add tests for what Dennis and you identified
as testable
|
73ba0b0
to
fbdc902
Compare
Signed-off-by: Dennis Wambua <[email protected]>
closes #892