Use xpath as key for valueLabels dict #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royrutto-xx
changed the title
|
@royrutto Some forms work, like the one you're testing with, but @faith-mutua and I get different errors |
denniswambua
reviewed
Feb 8, 2017
| @@ -737,10 +739,25 @@ def _get_sav_value_labels(self): | |||
| name = choice['name'].strip() | |||
| label = self.get_choice_label_from_dict(choice['label']) | |||
| _value_labels[name] = label.strip() | |||
| self._sav_value_labels[q['name']] = _value_labels | |||
| self._sav_value_labels[var_name or q['name']] = _value_labels | |||
There was a problem hiding this comment.
Should var_name be q['name'] when xpath_var_names in None?
denniswambua
approved these changes
Feb 8, 2017
denniswambua
force-pushed
the
sav-exports-fix
branch
from
fb82d15 to
10e98e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/onaio/core/issues/1305