Dataviews endpoint should not require auth for public dataviews. #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniswambua
changed the title
urbanslug
force-pushed
the
891-public-dataviews-require-auth
branch
2 times, most recently
from
90d9ee8 to
d29be25
Compare
urbanslug
changed the title
The dataviews endpoint should not require auth for public dataviews, `api/v1/dataviews/<public-dataview-id>`, filtered by the dataview id but should require auth for a request for all dataviews, `api/v1/dataviews`. Signed-off-by: Njagi Mwaniki <[email protected]>
urbanslug
force-pushed
the
891-public-dataviews-require-auth
branch
from
d29be25 to
f695509
Compare
denniswambua
suggested changes
Feb 13, 2017
| # To allow individual public dataviews to be visible on | ||
| # `api/v1/dataviews/<pk>` but stop retreival of all dataviews when | ||
| # the dataviews endpoint is queried `api/v1/dataviews` | ||
| return not (request.user.is_anonymous() and view.action == 'list') |
There was a problem hiding this comment.
remove the unnecessary parenthesis.
|
@denniswambua Done. |
urbanslug
force-pushed
the
891-public-dataviews-require-auth
branch
from
5279e48 to
f695509
Compare
- A GET request for *all* dataviews for unauthenticated users returns a 404. - A GET request for *all* dataviews for authenticated users checks whether they have the required permissions. - A GET request for *a specific* public dataview *always* returns a 200. - A GET request for *a specific* private dataview from unauthenticated users should return a 404 but from authenticated users should check whether they have the required permissions. Signed-off-by: Njagi Mwaniki <[email protected]>
urbanslug
force-pushed
the
891-public-dataviews-require-auth
branch
from
f695509 to
a4d469b
Compare
denniswambua
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dataviews endpoint should not require auth for public dataviews,
api/v1/dataviews/<public-dataview-id>, filtered by the dataview id but should require auth for a request for all dataviews,api/v1/dataviews.closes #891