Fix global teardown of loader handles and check driver status in init_driver #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Aug 20, 2024
nrspruit
commented
- Moved all loader handle maps to within the loader context to ensure the maps are init and destroyed with library init/destroy vs at start of atexit.
- Check result of individual driver for zeInit during init_driver().
nrspruit
force-pushed
the
fix_multi_driver_teardown_init
branch
from
19d59b1 to
209af0b
Compare
|
These should probably at least be two separate commits. Same PR is fine. |
I will split up the commits. |
- Moved all loader handle maps to within the loader context to ensure the maps are init and destroyed with library init/destroy vs at start of atexit. Signed-off-by: Neil R. Spruit <[email protected]>
-Check result of individual driver for zeInit during init_driver(). Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
fix_multi_driver_teardown_init
branch
from
209af0b to
05b5259
Compare
JablonskiMateusz
approved these changes
Aug 21, 2024
ArturHarasimiuk
approved these changes
Aug 21, 2024
|
Disregard my last comment, this should be ready to merge since it is not causing additional issues. |
- Fix the fallback case where multiple drivers are found, but only one inits such that the ddi tables are reinit to point back to the driver. Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
fix_multi_driver_teardown_init
branch
from
cfe26f0 to
2d80a32
Compare
Signed-off-by: Neil R. Spruit <[email protected]>
lisanna-dettwyler
previously approved these changes
Aug 21, 2024
Signed-off-by: Neil R. Spruit <[email protected]>
lisanna-dettwyler
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.