Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Replace Dawn.Guard with Throw and refactor domain validations #79

Closed
CesarD opened this issue Aug 5, 2024 · 0 comments · Fixed by #80
Closed

REFACTOR: Replace Dawn.Guard with Throw and refactor domain validations #79

CesarD opened this issue Aug 5, 2024 · 0 comments · Fixed by #80
Assignees
Labels
enhancement New feature or request

Comments

@CesarD
Copy link
Collaborator

CesarD commented Aug 5, 2024

Detailed Description

Replace argument validation library Dawn.Guard with Throw library. Refactor corresponding domain validations and use the occasion to improve them.

Context

Because the library Dawn.Guard has been abandoned by its author, it became required to find an alternative that allows to do something similar and that also gets good maintenance support from its author.
For this purpose, the library Throw from Amichai Mantinband is a very good candidate since it's been conceived taking Dawn.Guard as reference but also allows some extra features.
It was considered the use of GuardClauses, but its syntax and features made it less appealing than Throw.
Also, since it will be needed to refactor all the current domain validations, we can use the occasion to improve them and add some more of them on places where there should be some validations.
This will also require to refactor unit tests and improve them to cover different scenarios that were currently not taken into consideration.

@CesarD CesarD added the enhancement New feature or request label Aug 5, 2024
@CesarD CesarD self-assigned this Aug 5, 2024
CesarD added a commit that referenced this issue Aug 5, 2024
@CesarD CesarD linked a pull request Aug 5, 2024 that will close this issue
10 tasks
@CesarD CesarD closed this as completed in #80 Aug 9, 2024
@CesarD CesarD closed this as completed in 190bafa Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant