Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Negation filtering #45

Merged
merged 4 commits into from
May 26, 2023
Merged

FIX: Negation filtering #45

merged 4 commits into from
May 26, 2023

Conversation

Gonzo345
Copy link
Collaborator

Description

  • Fixes the negation filtering. Example: !0d251643-4026-45f1-a038-cd11e947be19 wasn't passing the validation where it actually should.
  • The ValidateDataType method wasn't taking into account that there is an exception where, if the input value comes with a ! at the beggining should be tried to be validated without it, as it's used for negating when filtering

Related Issue

Motivation and Context

  • Using Monaco template in a project, noticed using the negation while filtering wasn't working as expected.

How Has This Been Tested?

  • It's now working as expected

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Fixes the negation filtering. Example: !0d251643-4026-45f1-a038-cd11e947be19 wasn't passing the validation where it actually should

Co-Authored-By: César <[email protected]>
@Gonzo345 Gonzo345 added the bug Something isn't working label May 26, 2023
@Gonzo345 Gonzo345 requested a review from CesarD May 26, 2023 14:19
@Gonzo345 Gonzo345 self-assigned this May 26, 2023
Copy link
Collaborator

@CesarD CesarD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

But could you please bump the version to 2.0.4 so we can release a new version afterwards?

Gonzo345 and others added 3 commits May 26, 2023 16:24
- Not the infrastructure NuGet version

Co-Authored-By: César <[email protected]>
@CesarD CesarD merged commit a6dfaa8 into main May 26, 2023
@CesarD CesarD deleted the fix/Negation_filtering branch May 26, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants