[VA-4] toolbar #10
Merged
[VA-4] toolbar #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VicAv99
reviewed
Feb 11, 2020
| > | ||
| </details> | ||
| </main> | ||
| <vulnerability-checker-ui-toolbar> |
There was a problem hiding this comment.
Shouldn't the selector be gc instead of vulnerability-checker?
VicAv99
reviewed
Feb 11, 2020
VicAv99
reviewed
Feb 11, 2020
VicAv99
reviewed
Feb 11, 2020
VicAv99
reviewed
Feb 11, 2020
| MatTooltipModule, | ||
| MatTreeModule, | ||
| } from '@angular/material'; | ||
| import {A11yModule} from '@angular/cdk/a11y'; |
There was a problem hiding this comment.
Do we need all of these CDK imports? I don't think we will be using them all.
VicAv99
reviewed
Feb 11, 2020
VicAv99
reviewed
Feb 11, 2020
| </span> | ||
|
|
||
| <form> | ||
| <mat-form-field class="search" appearance="none"> |
There was a problem hiding this comment.
formatting seems a bit off in this file
VicAv99
reviewed
Feb 11, 2020
VicAv99
reviewed
Feb 11, 2020
| @@ -0,0 +1,42 @@ | |||
| @import '../../../../theme/theme.scss'; | |||
|
|
|||
| mat-toolbar { | |||
There was a problem hiding this comment.
Do we have the bootstrap-utilities and bootstrap-4-grid classes installed yet? Most of these styles can go away by leveraging those.
VicAv99
reviewed
Feb 11, 2020
| @import '../../../../theme/theme.scss'; | ||
|
|
||
| mat-toolbar { | ||
| display: flex; |
There was a problem hiding this comment.
Also, styles in this file will leak out, you need to encapsulate your styles in here now.
… material bootstrap module
Co-Authored-By: Victor Avila <[email protected]>
VicAv99
reviewed
Feb 11, 2020
|
/rebase |
VicAv99
approved these changes
Feb 11, 2020
davidavila2
pushed a commit
that referenced
this pull request
Feb 19, 2020
* added toolbar * fixed styling on toolbar, added bootstrap utilities, removed cdk from material bootstrap module * Apply suggestions from code review Co-Authored-By: Victor Avila <[email protected]> * changed formating, added bootstrap-4-grid * removed default font styles, formatted scss files * [VA-000]: create pr template and remove extensions.json (#11) * chore: create pr template and remove extensions.json * chore: add actions Co-authored-by: David Avila <[email protected]> * Update libs/ui-libraries/src/lib/ui-toolbar/ui-toolbar.component.scss * chore: remove .md from template * [VA-4] toolbar (#10) * added toolbar * fixed styling on toolbar, added bootstrap utilities, removed cdk from material bootstrap module * Apply suggestions from code review Co-Authored-By: Victor Avila <[email protected]> * changed formating, added bootstrap-4-grid * removed default font styles, formatted scss files * Update libs/ui-libraries/src/lib/ui-toolbar/ui-toolbar.component.scss Co-authored-by: Victor Avila <[email protected]> * Update libs/ui-libraries/src/lib/ui-toolbar/ui-toolbar.component.scss Co-Authored-By: Victor Avila <[email protected]> * Update apps/vulnerability-checker/src/index.html Co-Authored-By: Victor Avila <[email protected]> * Update libs/theme/_variables.scss Co-Authored-By: Victor Avila <[email protected]> * Update libs/theme/theme.scss Co-Authored-By: Victor Avila <[email protected]> * generate auth and user services * Generated Auth * remove git workflows. * [VA-8] info (#16) * created repo-info component * refactored css in repo-info, and ui-toolbar * cleaned up styling --david * last chnage. changed order of css classes * fix styles accordingly to PR * fixed styling on toolbar and repo info Co-authored-by: David Avila <[email protected]> * [VA-17] global styles (#17) * generated fonts.scss, and updated main.scss * updated font styles in info component Co-authored-by: elideg <[email protected]> Co-authored-by: Victor Avila <[email protected]>
davidavila2
pushed a commit
that referenced
this pull request
Feb 21, 2020
* Merge Develop into Master (#21) * added toolbar * fixed styling on toolbar, added bootstrap utilities, removed cdk from material bootstrap module * Apply suggestions from code review Co-Authored-By: Victor Avila <[email protected]> * changed formating, added bootstrap-4-grid * removed default font styles, formatted scss files * [VA-000]: create pr template and remove extensions.json (#11) * chore: create pr template and remove extensions.json * chore: add actions Co-authored-by: David Avila <[email protected]> * Update libs/ui-libraries/src/lib/ui-toolbar/ui-toolbar.component.scss * chore: remove .md from template * [VA-4] toolbar (#10) * added toolbar * fixed styling on toolbar, added bootstrap utilities, removed cdk from material bootstrap module * Apply suggestions from code review Co-Authored-By: Victor Avila <[email protected]> * changed formating, added bootstrap-4-grid * removed default font styles, formatted scss files * Update libs/ui-libraries/src/lib/ui-toolbar/ui-toolbar.component.scss Co-authored-by: Victor Avila <[email protected]> * Update libs/ui-libraries/src/lib/ui-toolbar/ui-toolbar.component.scss Co-Authored-By: Victor Avila <[email protected]> * Update apps/vulnerability-checker/src/index.html Co-Authored-By: Victor Avila <[email protected]> * Update libs/theme/_variables.scss Co-Authored-By: Victor Avila <[email protected]> * Update libs/theme/theme.scss Co-Authored-By: Victor Avila <[email protected]> * generate auth and user services * Generated Auth * remove git workflows. * [VA-8] info (#16) * created repo-info component * refactored css in repo-info, and ui-toolbar * cleaned up styling --david * last chnage. changed order of css classes * fix styles accordingly to PR * fixed styling on toolbar and repo info Co-authored-by: David Avila <[email protected]> * [VA-17] global styles (#17) * generated fonts.scss, and updated main.scss * updated font styles in info component Co-authored-by: elideg <[email protected]> Co-authored-by: Victor Avila <[email protected]> * add: utilities file in theme lib * update repo-info to use utilities * updated ui-toolbar to use utilities * removed unneccessary imports Co-authored-by: David Avila <[email protected]> Co-authored-by: elideg <[email protected]> Co-authored-by: Victor Avila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed template code from app component/scss, created material barrel roll module, added core-functionality to ui-toolbar.