Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUI-290/add to internal npm registry #3

Merged
merged 7 commits into from
Apr 12, 2024
Merged

Conversation

johndocks
Copy link

@johndocks johndocks commented Apr 11, 2024

As part of an effort to remove hardcoded credentials, we are moving internal npm packages to use the internal npm registry. This PR:

  • removes CircleCI pipeline files (moving to github actions)
  • updates the name of the package in the package.json file
  • adds an .npmrc file
  • updates instructions in README

@johndocks johndocks requested review from pjlong and removed request for pjlong April 11, 2024 18:37
"version": "0.2.0",
"author": "Kamil Socha (https://github.com/ksocha)",
"description": "Cypress test reporter for CircleCI",
"license": "MIT",
"repository": {
"type": "git",
"url": "git+https://github.com/ksocha/cypress-circleci-reporter.git"
"url": "git+https://github.com/onemedical/cypress-circleci-reporter.git"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice, good catch

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed on purpose?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh gotcha, moving to github actions. Nice.

@johndocks johndocks added this pull request to the merge queue Apr 12, 2024
Merged via the queue into master with commit 3cdb9a4 Apr 12, 2024
1 check passed
@johndocks johndocks deleted the PUI-290/add-to-npm branch April 12, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants