This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
INT-441: Add Onfleet nodes to n8n #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Onfleet nodes for working with different endpoints like: organizations, administrators, workers, hubs, teams, destinations, recipients, containers and webhooks.
jamesliupenn
suggested changes
Dec 16, 2021
packages/nodes-base/nodes/Onfleet/descriptions/TaskDescription.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Onfleet/descriptions/TaskDescription.ts
Outdated
Show resolved
Hide resolved
jamesliupenn
changed the title
|
Will be working on functional testing as well today, I'll comment on the JIRA ticket for any additional change requests |
jamesliupenn
suggested changes
Dec 20, 2021
packages/nodes-base/nodes/Onfleet/descriptions/DestinationDescription.ts
Show resolved
Hide resolved
| @@ -595,14 +591,14 @@ export class Onfleet implements INodeType { | |||
| try { | |||
| if (operation === 'create') { | |||
| /* -------------------------------------------------------------------------- */ | |||
| /* Add new task */ | |||
| /* Add a new task */ | |||
| /* -------------------------------------------------------------------------- */ | ||
| responseData.push(...await onfleetApiRequest.call(this, 'GET', encodedApiKey, resource)); | ||
| } else if (operation === 'create') { | ||
| /* -------------------------------------------------------------------------- */ | ||
| /* Add new admin */ | ||
| /* Add a new admin */ |
| @@ -894,7 +890,7 @@ export class Onfleet implements INodeType { | |||
| responseData.push(...await onfleetApiRequest.call(this, 'GET', encodedApiKey, resource)); | |||
| } else if (operation === 'create') { | |||
| /* -------------------------------------------------------------------------- */ | |||
| /* Add new hub */ | |||
| /* Add a new hub */ | |||
| @@ -959,7 +955,7 @@ export class Onfleet implements INodeType { | |||
| responseData.push(await onfleetApiRequest.call(this, 'GET', encodedApiKey, path, {}, workerFilters)); | |||
| } else if (operation === 'create') { | |||
| /* -------------------------------------------------------------------------- */ | |||
| /* Add new worker */ | |||
| /* Add a new worker */ | |||
| }, | ||
| }, | ||
| options: [ | ||
| { | ||
| name: 'Add', | ||
| value: 'create', | ||
| description: 'Add new Onfleet admin.', | ||
| description: 'Add a new Onfleet admin.', |
jamesliupenn
suggested changes
Dec 21, 2021
There was a problem hiding this comment.
Everything else looks great, except for something that probably I failed to communicate. We should update the language to say Create a <Onfleet_object> instead of Add a <Onfleet_object> so we stay true to ourselves. I see that the value has been updated but the displayed language to n8n users still uses add
You can see https://docs.onfleet.com/reference#workers & https://docs.onfleet.com/reference#create-team, we all specify Create a worker or Create a team instead of Add.
Once fixed, I think I will merge this into master ;)
IGNORE me, I didn't see the latest commit, this is approved
jamesliupenn
approved these changes
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Onfleet nodes for working with different endpoints like: organizations, administrators, workers, hubs, teams,
destinations, recipients, containers and webhooks.