This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Refactor according to n8n PR comments #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 27, 2022 09:38
added new fixed collections, refactored the code according to comments made on the n8n pr
added docstrings for new functions addded for formatting the destination and recipient objects
jamesliupenn
suggested changes
Feb 2, 2022
packages/nodes-base/nodes/Onfleet/descriptions/TaskDescription.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Onfleet/descriptions/TaskDescription.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Onfleet/descriptions/RecipientDescription.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Onfleet/descriptions/OrganizationDescription.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Onfleet/descriptions/DestinationDescription.ts
Outdated
Show resolved
Hide resolved
|
@YokySantiago please check the latest notes and make the changes accordingly, otherwise, everything else looks good to me! |
|
Lgtm, merging |
jamesliupenn
reviewed
Feb 2, 2022
|
Well, my checkmark disappeared and I cannot locate to actually approve this on Github...... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes have been added according to n8n PR comments so, now we have:
Also, the code is formatted with nodelinter.