Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a way to represent "all entitlements" #2635

Closed
SupunS opened this issue Jul 6, 2023 · 2 comments
Closed

Introduce a way to represent "all entitlements" #2635

SupunS opened this issue Jul 6, 2023 · 2 comments

Comments

@SupunS
Copy link
Member

SupunS commented Jul 6, 2023

Issue to be solved

Need a way to represent "all entitlements", e.g: something authorized to have the same access as owner-access has.

Refer to the discussion here: #2588 (comment)

Suggested Solution

No response

@turbolent
Copy link
Member

turbolent commented Aug 10, 2023

Let's see if the edge-case for which this was proposed is actually encountered in the real-world, it might not be necessary at all.

@dsainati1
Copy link
Contributor

I am against adding any kind of owner entitlement. It would introduce a huge footgun into the language by allowing users to accidentally hand out more authority/permission than they had intended to. The current design forces users to explicitly list out all the entitlements/permissions they are intending to provide, this would allow users to bypass this easily. Indeed this would make the anti-pattern easier and more convenient than the correct pattern.

Additionally I think the use case presented in #2588 (comment) is an edge case that is not worth introducing such a large change into the language to solve it. We are expecting a very small portion of users to actually use entitlement mappings, and even smaller portion of those to use mappings that include the identity. This use case only comes up when someone uses both these features on a field with an AnyStruct or AnyResource type, and as such should be vanishingly rare. I agree we can reconsider this if people start complaining, but I would do so with a lot of caution.

@turbolent turbolent closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants