Return a reference with all entitlements, when access through owned values #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onflow/cadence into supun/identity-mapping-improvement
SupunS
commented
Jul 6, 2023
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:feature/mutability-restrictions commit 8fe5295 Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## feature/mutability-restrictions #2637 +/- ##
================================================================
Coverage 78.89% 78.90%
================================================================
Files 341 341
Lines 81820 81850 +30
================================================================
+ Hits 64555 64585 +30
Misses 14909 14909
Partials 2356 2356
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
It would be good to get a review from @dsainati1 here before merging |
SupunS
force-pushed
the
supun/identity-mapping-improvement
branch
from
b52fa45 to
a54cad8
Compare
dsainati1
reviewed
Jul 10, 2023
There was a problem hiding this comment.
Nice, thank you for adding this. Does this also address #2588 (comment)?
I don't see any updated tests here, so if this is not fixed by this PR I think it can be just by using this same AllSupportedEntitlements functionality.
|
@dsainati1 No it doesn't address #2588 (comment). Like discussed there, it is impossible to know all possible entitlements for a |
Ah okay I see the problem. In that case I think the current behavior is fine actually; after thinking about it further this is not the only case with the It is somewhat unusual to realize that the |
dsainati1
reviewed
Jul 10, 2023
SupunS
force-pushed
the
supun/identity-mapping-improvement
branch
from
e2ccbb0 to
76e239e
Compare
SupunS
force-pushed
the
supun/identity-mapping-improvement
branch
from
76e239e to
842a9cd
Compare
dsainati1
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #2638
Work towards onflow/flips#94
Closes #2536
Description
Adds the improvement discussed in #2588 (comment)
masterbranchFiles changedin the Github PR explorer