Add equal method for cadence external types #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupunS
commented
Dec 21, 2022
Comment on lines
-2691
to
-2696
| // constructors | ||
|
|
||
| if t.IsConstructor != otherFunction.IsConstructor { | ||
| return false | ||
| } | ||
|
|
There was a problem hiding this comment.
A code cleanup; This check is already done above
SupunS
force-pushed
the
supun/type-equal
branch
from
0bd76f9 to
ea8303f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2203 +/- ##
==========================================
+ Coverage 77.58% 77.68% +0.09%
==========================================
Files 309 309
Lines 65409 65663 +254
==========================================
+ Hits 50750 51011 +261
+ Misses 12880 12874 -6
+ Partials 1779 1778 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
SupunS
force-pushed
the
supun/type-equal
branch
2 times, most recently
from
ab90cd0 to
6feb7b9
Compare
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit ed1c493 Collapsed results for better readability
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
SupunS
force-pushed
the
supun/type-equal
branch
from
6feb7b9 to
3a9ece4
Compare
|
Oh, this should be ready to review. Work here is done, kept it as a draft until the CI passes, and then forgot to change the state. |
dsainati1
approved these changes
Jan 3, 2023
turbolent
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2199
Description
Adds
Type.Equal(Type) boolmethod for cadence external types, sinceType.ID()cannot be used to compare some types (e.g: restricted types). This newly addedEqual()method compares go structs recursively and hence doesn't do allocations (except for the restricted types).masterbranchFiles changedin the Github PR explorer