Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for overloaded declaration #2738

Merged
merged 5 commits into from
Aug 28, 2023
Merged

Improve error message for overloaded declaration #2738

merged 5 commits into from
Aug 28, 2023

Conversation

PratikDhanave
Copy link
Contributor

@PratikDhanave PratikDhanave commented Aug 20, 2023

Closes #520

Description


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

Please fill out the description template.

runtime/sema/errors.go Outdated Show resolved Hide resolved
@turbolent turbolent changed the title Issues 520 Improve error message for overloaded declaration Aug 21, 2023
@PratikDhanave
Copy link
Contributor Author

hi @turbolent @SupunS I have update pr please review

@PratikDhanave
Copy link
Contributor Author

PratikDhanave commented Aug 28, 2023

hi @turbolent @SupunS I have update pr please review

hi @turbolent thank you for review I have resolved the comments

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #2738 (9132dfa) into master (016525d) will increase coverage by 0.07%.
Report is 35 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2738      +/-   ##
==========================================
+ Coverage   79.11%   79.18%   +0.07%     
==========================================
  Files         333      333              
  Lines       78194    78536     +342     
==========================================
+ Hits        61861    62192     +331     
- Misses      14041    14043       +2     
- Partials     2292     2301       +9     
Flag Coverage Δ
unittests 79.18% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
runtime/sema/check_composite_declaration.go 95.79% <100.00%> (+0.02%) ⬆️

... and 11 files with indirect coverage changes

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@turbolent turbolent merged commit 1bbc078 into onflow:master Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify error messages for function/constructor overloading
3 participants