Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error range when reporting a type error for an indexing reference expression #719

Merged

Conversation

turbolent
Copy link
Member

Description

Fix the range in the type mismatch error reported for an indexing reference expression.

Unfortunately, for historic reasons, index expressions' start position is currently the opening square bracket and not the indexed expression's start position.

I opened #718 to fix the node and thus all other potential cases.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Mar 22, 2021
@turbolent turbolent merged commit 0aa6bc4 into master Mar 23, 2021
@turbolent turbolent deleted the bastian/fix-reference-to-index-expression-error-range branch March 23, 2021 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants