This repository has been archived by the owner on Sep 8, 2023. It is now read-only.
Integrate Sentry monitoring without Remix SDK #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingone21
changed the title
schpet
approved these changes
Jun 27, 2022
app/entry.server.tsx
Outdated
| Sentry.init({ | ||
| dsn: getRequiredGlobalEnvVar("SENTRY_DSN"), | ||
| tracesSampleRate: 0.3, | ||
| environment: getRequiredGlobalEnvVar("NODE_ENV"), |
There was a problem hiding this comment.
can this be changed to SENTRY_ENV ? this will allow me to separate staging and production events, which both use NODE_ENV=production
There was a problem hiding this comment.
Do you mean adding a SENTRY_ENV env var like so?
Sentry.init({
dsn: getRequiredGlobalEnvVar("SENTRY_DSN"),
tracesSampleRate: 0.3,
environment: getRequiredGlobalEnvVar("SENTRY_ENV")
Do we already have SENTRY_ENV setup that differentiates 'staging'/'production'? I'm wondering why can't we just specify 'staging'/'production' in NODE_ENV?
There was a problem hiding this comment.
For instance, using SENTRY_ENV='sentry' as a env var will look like this. This should work, but I don't know how to set this up for staging/prod
…tion * origin/main: Improve behavior of getRequiredEnvVarFromObj (#337)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented basic sentry monitoring system by checking 500 responses from the server. While this isn't ideal for tracing (every error will be found at handleRequest(..)), we can still monitor errors through events and breadcrumbs like so:
.This is a simple and temporarily implementation as Remix SDK for Sentry is under development: getsentry/sentry-javascript#4894