Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground Feature: Multiple contracts per account - Milestone 1 #118

Merged
merged 3 commits into from
Nov 4, 2021

Conversation

bartolomej
Copy link
Contributor

@bartolomej bartolomej commented Oct 31, 2021

Playground Feature: Multiple contracts per account - Milestone 1

Description

This PR is for issue #21.

List of completed requirements:

  • add UI wireframe
  • add UI example implementation
  • include a rough description of backend changes

Submission Links & Documents

Requirements Check

  • Have have you met the milestone requirements? YES
  • Have you included tests (if applicable)? N/A
  • Have you met the contribution guidelines of the repos you have submitted code to (if applicable)? YES
  • If this is the last milestone:
    • Demonstrate that you've met all the acceptance criteria (link to code, demos, instructions to run etc.)
    • Demonstrate that you've met all milestone requirements and highlight any extensions or additional work done.
    • Include a payout structure by percentage for each team member (ie. Bob: 20%, Alice: 80%).

Other Details

  • Is there anything specific you'd like the PoC to know or review for?

    Yes, we included a list of questions here

@kerrywei kerrywei requested a review from MaxStalker November 1, 2021 17:06
@MaxStalker
Copy link
Contributor

🎉 Milestone Achieved 🎉
I like your solution with tree structure for deployed contracts. It's close to what we currently have and easier to display contract status that way.

Unfortunately, I don't have the answers to your questions about current schema and duplication logic 😅
I can fetch them internally and get back to you.

@MaxStalker MaxStalker merged commit a3fbcef into onflow:main Nov 4, 2021
@bartolomej bartolomej mentioned this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants