Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Standard: NFT metadata #16 - Milestone 1 #64

Merged
merged 5 commits into from
Oct 27, 2021

Conversation

0xJayShen
Copy link
Contributor

This PR is for issue #16

Have have you met the milestone requirements? yes
Have you included tests (if applicable)? no

@kerrywei kerrywei requested a review from joshuahannan October 15, 2021 18:54
@joshuahannan
Copy link
Member

Hey, thanks for the submission! Can you elaborate on how you think this could integrate into the existing NFT standard? Any upgrade should probably be backwards compatible with the existing standard. If not, can you explain why?

and can you also provide more detail about why you chose to require each fields in this specification?

Thank you!

@0xJayShen
Copy link
Contributor Author

0xJayShen commented Oct 18, 2021

Hey, thanks for the submission! Can you elaborate on how you think this could integrate into the existing NFT standard? Any upgrade should probably be backwards compatible with the existing standard. If not, can you explain why?

and can you also provide more detail about why you chose to require each fields in this specification?

Thank you!

Added comments, hope to make some additions

@joshuahannan
Copy link
Member

I don't actually see any sample code. Could you include an example implementation?
Also, how would you expect projects to be interoperable with this standard? We would ideally need some sort of standard interface that 3rd parties could use to interact with projects that use these

@0xJayShen
Copy link
Contributor Author

I don't actually see any sample code. Could you include an example implementation? Also, how would you expect projects to be interoperable with this standard? We would ideally need some sort of standard interface that 3rd parties could use to interact with projects that use these

Can I add example code and tests in subsequent milestones? This pr is the result of my Milestone 1.

@joshuahannan
Copy link
Member

Good point. You can add sample code in future milestones. We can probably merge this. 👍

@joshuahannan
Copy link
Member

@kerrywei @srinjoyc Can one of you merge this? I don't have permission

@srinjoyc
Copy link
Contributor

Will do, thanks @joshuahannan

@srinjoyc srinjoyc merged commit d4654b9 into onflow:main Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants