-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Standard: NFT metadata #16 - Milestone 1 #64
Conversation
Hey, thanks for the submission! Can you elaborate on how you think this could integrate into the existing NFT standard? Any upgrade should probably be backwards compatible with the existing standard. If not, can you explain why? and can you also provide more detail about why you chose to require each fields in this specification? Thank you! |
Added comments, hope to make some additions |
I don't actually see any sample code. Could you include an example implementation? |
Can I add example code and tests in subsequent milestones? This pr is the result of my Milestone 1. |
Good point. You can add sample code in future milestones. We can probably merge this. 👍 |
Will do, thanks @joshuahannan |
This PR is for issue #16
Have have you met the milestone requirements? yes
Have you included tests (if applicable)? no