Update core contracts to latest stable cadence

[SupunS]

No description provided.

[joshuahannan]

Thank you for making all these changes! I really appreciate it. I just had a few comments and questions

[turbolent]

Great work! That was a lot of code to update, well done! 👏

Looks good in general 👍

Only really one suggestion throughout: Account.capabilities.borrow can be used instead of get + borrow

[turbolent]

Great work! 👏 So many files! 😮‍💨😰

Maybe run the parse tool on all the transactions to at least check they're syntactically are OK: https://github.com/onflow/cadence/tree/master/runtime/cmd/parse.

Maybe also the check tool can be run on the transactions?

[SupunS]

I think the existing tests should already cover parsing/checking/interpreting all transactions/contracts. But unfortunately, not all tests are passing at the moment because not everything is migrated completely. (i.e. the base branch stable-cadence tests are also failing). I tested the contracts used by flow-go, emulator, and CLI, and made sure they were all correct. But as for the rest, their correctness would only be guaranteed once the tests are passing

[turbolent]

Tried to fix and improve some more things in 196c87a.
@SupunS Could you please have a look and check these manual/untested changes work and do not break anything?

There are a couple more things I noticed:

• Some transactions still use restricted types:

  • transactions/flowToken/scripts/get_balance.cdc
  • transactions/flowToken/setup_account.cdc

• TESTFlowStakingCollection replaces access(self) with pub. Should be access(all) now

In general, the use of the invalid import 0xFOO syntax in Cadence programs prevents them from being parsed and checked by tools, and I also think not editable using IDEs / with the Language Server.

The imports should be changed to the supported, and standardized syntax (FLIP). Probably best in a separate, follow-up PR to not increase the scope of this PR.

[SupunS]

@turbolent I re-generated the assets and tested with flow-go. Needed just one minor adjustment, and everything looks good: https://github.com/onflow/flow-go/actions/runs/6315719064/job/17148896286?pr=4762

[SupunS]

I guess we can merge this PR at the current state, and do the remaining migrations in follow-up PRs.

[turbolent]

Yep, looks good!

From what I can see in the test logs, only the state commitments are (expectedly) off

[SupunS]

From what I can see in the test logs, only the state commitments are (expectedly) off

Yes, correct.