Restructure directories and contract content + README updates #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisyphusSmiling
added
Feature
Breaking Change
Documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 82.88% 85.56% +2.67%
==========================================
Files 18 19 +1
Lines 818 859 +41
==========================================
+ Hits 678 735 +57
+ Misses 140 124 -16 ☔ View full report in Codecov by Sentry. |
sisyphusSmiling
changed the title
joshuahannan
approved these changes
Apr 26, 2024
Comment on lines
+172
to
+177
| Similarly, Cadence contracts can implement the [`IBridgePermissions.cdc` contract | ||
| interface](./cadence/contracts/bridge/interfaces/IBridgePermissions.cdc). This contract has a single method | ||
| `allowsBridging()` with a default implementation returning `false`. Again, the bridge explicitly checks for the | ||
| implementation of `IBridgePermissions` and the value of `allowsBridging()` to validate that the contract has not opted | ||
| out of bridging. Should you later choose to enable bridging, you can simply override the default implementation and | ||
| return true. |
There was a problem hiding this comment.
It would be good to get this added to the V2 standards so we can show that every NFT contract needs to be cognizant about if they want to allow bridging or not. Can you make a PR to the v2 standard branch?
There was a problem hiding this comment.
Definitely, I can follow up with a PR early next week
Co-authored-by: Joshua Hannan <[email protected]>
sisyphusSmiling
force-pushed
the
repo-reorg
branch
from
f936101 to
d0a2a0d
Compare
Co-authored-by: Joshua Hannan <[email protected]>
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #29 #47 #49 #50
Stacked on: #48
Description
For contributor use:
masterbranchFiles changedin the Github PR explorer