Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support secp256k1 in DecodePublicKeyPEM #176

Closed
Kay-Zee opened this issue Mar 23, 2021 · 0 comments · Fixed by #183
Closed

Support secp256k1 in DecodePublicKeyPEM #176

Kay-Zee opened this issue Mar 23, 2021 · 0 comments · Fixed by #183
Assignees
@tarakby
Labels
Improvement

Comments

@Kay-Zee
Copy link
Member

Kay-Zee commented Mar 23, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently, DecodePublicKeyPEM only supports P256, would be great to support both signing algs (i.e. add secp256k1 support)

Describe the solution you'd like
As described by @tarakby here: #175 (comment)

Describe alternatives you've considered
N/A

Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tarakby tarakby

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Crypto] DecodePublicKeyPEM supports ECDSA secp256k1 keys onflow/flow-go-sdk
2 participants
@Kay-Zee @tarakby