Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crypto] DecodePublicKeyPEM supports ECDSA secp256k1 keys #183

Merged
merged 3 commits into from
May 4, 2021

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Apr 8, 2021

Closes: #176

Description

  • refactor DecodePublicKeyPEM to optimize an extra round of decoding and encoding.
  • add support for ECDSA keys for secp256k1.
  • improve the tests.

@tarakby tarakby requested a review from Kay-Zee April 8, 2021 23:46
@tarakby tarakby self-assigned this Apr 8, 2021
Copy link
Contributor

@psiemens psiemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@Kay-Zee Kay-Zee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @tarakby

@Kay-Zee Kay-Zee merged commit b2c5519 into master May 4, 2021
@tarakby tarakby deleted the tarak/176-decode-pkPEM branch April 3, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support secp256k1 in DecodePublicKeyPEM
3 participants