Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include domain tag when signing transactions #61

Closed
2 tasks
psiemens opened this issue Jun 18, 2020 · 2 comments · Fixed by #184
Closed
2 tasks

Include domain tag when signing transactions #61

psiemens opened this issue Jun 18, 2020 · 2 comments · Fixed by #184
Assignees
@psiemens @janezpodhostnik
Labels
Improvement Needs Test Cases

Comments

@psiemens
Copy link
Contributor

When signing a transaction, the message being signed should be prefixed with the transaction domain tag (TBD).

The tag should be prepended to the byte slice returned by the PayloadMessage() and EnvelopeMessage() functions on flow.Transaction.

Definition of Done

  • PayloadMessage produces a message that is prefixed with the transaction domain tag
  • EnvelopeMessage produces a message that is prefixed with the transaction domain tag

cc @tarakby
@psiemens psiemens self-assigned this Jun 18, 2020
@laynelafrance laynelafrance self-assigned this Jan 18, 2021
@bjartek bjartek mentioned this issue Feb 24, 2021
Closed
This was referenced Mar 2, 2021
Closed
Closed
@janezpodhostnik
Copy link
Contributor

janezpodhostnik commented Mar 3, 2021 •
edited
Loading

Is this something every SDK will need? I assume so. Where can I read more about this? is this connected to a flow-go change? @psiemens

@sudojbird
Copy link

@psiemens is this planned for Sprint 34?

@tarakby tarakby assigned tarakby and unassigned laynelafrance May 4, 2021
@sudojbird sudojbird assigned janezpodhostnik and unassigned tarakby May 4, 2021
@psiemens psiemens mentioned this issue May 4, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psiemens psiemens

@janezpodhostnik janezpodhostnik

Labels
Improvement Needs Test Cases
Projects
None yet
Milestone
No milestone
6 participants
@psiemens @laynelafrance @sifmoon @tarakby @janezpodhostnik @sudojbird