Introduce transaction domain tag #184
Conversation
|
@tarakby can you please have a look here? |
| sig, err := signer.Sign(t.EnvelopeMessage()) | ||
| message := t.EnvelopeMessage() | ||
| message = append(t.TransactionDomainTag, message...) | ||
| sig, err := signer.Sign(message) |
There was a problem hiding this comment.
The comment doesn't belong to the code above:
Does the SDK also implement verifications for the payload and envelope signatures? If yes, then the tag needs to be prepended to the message in those functions as well.
There was a problem hiding this comment.
No, the Go SDK doesn't have any transaction signature verification functionality.
There was a problem hiding this comment.
Thanks @peter!
Do you know if there is a flow-go issue to mirror this SDK change in the verifications on the FVM side ?
There was a problem hiding this comment.
@tarakby this is the change in flow-go onflow/flow-go#606
| sig, err := signer.Sign(t.EnvelopeMessage()) | ||
| message := t.EnvelopeMessage() | ||
| message = append(t.TransactionDomainTag, message...) | ||
| sig, err := signer.Sign(message) |
There was a problem hiding this comment.
No, the Go SDK doesn't have any transaction signature verification functionality.
janezpodhostnik
force-pushed
the
janez/transaction-domain-tag
branch
from
c5e431e to
05031d5
Compare
Closes: #61
Description
Added the transaction domain tag before signing the transaction. The transaction domain tag can be changed, but it has to be changed by all signing parties (if the tx is encoded/decoded when passed from one signer to another signer).
For contributor use:
masterbranchFiles changedin the Github PR explorer