-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Seals to BlockPayload #147
Conversation
af4dd06
to
a613377
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @beaugunderson, thanks for adding this!
I added a comment about tests, but the code itself looks great 👍
Also, can you run gofmt and push the changes? Looks like some of the indentation is off in a few places
a613377
to
26fc518
Compare
@psiemens tests added and should the potential issue with the Access API be tracked somewhere btw? (the one re: this block among others not having any seals via the explorer or the flow-sdk) |
test/entities.go
Outdated
@@ -131,8 +131,11 @@ func (g *Blocks) New() *flow.Block { | |||
g.guarantees.New(), | |||
} | |||
|
|||
seals := []*flow.BlockSeal{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the new BlockSeals
generator here, similar to g.guarantees
above.
I'd probably just add a single seal to each block:
seals := []*flow.BlockSeal{
g.seals.New(),
}
Thanks for adding the generator, BTW!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psiemens great, added that (and the corresponding instantiation) 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks again
Closes: #148
Description
Implements the
Seals
property ofBlockPayload
using the technique used forCollectionGuarantees
as a guide.Some context on Discord.
For contributor use:
master
branchFiles changed
in the Github PR explorer