Add ExecutionReceiptSignatures and ResultApprovalSignatures to BlockSeal #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beaugunderson
requested review from
janezpodhostnik,
psiemens and
turbolent
as code owners
psiemens
approved these changes
Apr 15, 2021
turbolent
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
ExecutionReceiptSignaturesandResultApprovalSignaturestoBlockSealwith no conversion. I looked a bit at the verifier code inflow-gobut am unsure if these should be represented as[][]byteor as something more structured; they seem to be generated fromcrypto.Signature.Also added some comments; please check to ensure my understanding is correct. :)
For contributor use:
masterbranchFiles changedin the Github PR explorer