Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crypto] Simplify nested key structures #182

Merged
merged 2 commits into from
Apr 14, 2021
Merged

[Crypto] Simplify nested key structures #182

merged 2 commits into from
Apr 14, 2021

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Apr 8, 2021 •
edited
Loading

This PR doesn't address any ticket.

  • simplifies the private and public key structures by using the flow-go/crypto structures.
  • cleans up redundant functions.

turbolent
turbolent approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

psiemens
psiemens approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@psiemens psiemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the links you sent about aliases in Go -- this change looks good to me.

@tarakby tarakby merged commit 335a278 into master Apr 14, 2021
@tarakby tarakby deleted the tarak/simplify-public-private-key-types branch April 3, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@psiemens psiemens psiemens approved these changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarakby @turbolent @psiemens