Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WaitServer method #578

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Add WaitServer method #578

merged 3 commits into from
Feb 29, 2024

Conversation

chasefleming
Copy link
Member

@chasefleming chasefleming commented Feb 13, 2024

Closes: #577

I will cherry pick this to a PR on the master branch after merged.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@chasefleming chasefleming marked this pull request as draft February 13, 2024 23:16
@chasefleming chasefleming changed the title Add call options to Ping Add WaitServer method Feb 15, 2024
@chasefleming chasefleming marked this pull request as ready for review February 15, 2024 00:09
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (66d5a88) 62.30% compared to head (150b76d) 62.26%.

Files Patch % Lines
access/grpc/client.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            v0.41     #578      +/-   ##
==========================================
- Coverage   62.30%   62.26%   -0.05%     
==========================================
  Files          24       24              
  Lines        2966     2968       +2     
==========================================
  Hits         1848     1848              
- Misses        994      996       +2     
  Partials      124      124              
Flag Coverage Δ
unittests 62.26% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chasefleming
Copy link
Member Author

chasefleming commented Feb 27, 2024

@turbolent @nvdtf @janezpodhostnik @sideninja @bluesign does this also look good to merge to you?

@bluesign
Copy link
Contributor

looks good to me

@chasefleming chasefleming merged commit 6434b7e into v0.41 Feb 29, 2024
1 check passed
@chasefleming chasefleming deleted the chasefleming/ping-opts branch February 29, 2024 21:00
chasefleming added a commit that referenced this pull request Feb 29, 2024
@chasefleming chasefleming mentioned this pull request Feb 29, 2024
6 tasks
@chasefleming
Copy link
Member Author

@janezpodhostnik @bluesign @jribbink I cherry picked this over to master as well. Here is the PR: #593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants