-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor subscribe func and stream mock object #781
refactor subscribe func and stream mock object #781
Conversation
@peterargue cc |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #781 +/- ##
==========================================
- Coverage 57.04% 56.59% -0.46%
==========================================
Files 35 35
Lines 7391 7305 -86
==========================================
- Hits 4216 4134 -82
+ Misses 2673 2670 -3
+ Partials 502 501 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much cleaner. added a few comments, but generally this looks good
@illia-malachyn looks good. please merge master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Closes: #763