Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor subscribe func and stream mock object #781

Conversation

illia-malachyn
Copy link
Contributor

Closes: #763

@illia-malachyn
Copy link
Contributor Author

@peterargue cc

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 78.37838% with 24 lines in your changes missing coverage. Please review.

Project coverage is 56.59%. Comparing base (9f84549) to head (e2f4c9d).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
access/grpc/grpc.go 83.65% 14 Missing and 3 partials ⚠️
access/grpc/convert/convert.go 0.00% 5 Missing ⚠️
account.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage   57.04%   56.59%   -0.46%     
==========================================
  Files          35       35              
  Lines        7391     7305      -86     
==========================================
- Hits         4216     4134      -82     
+ Misses       2673     2670       -3     
+ Partials      502      501       -1     
Flag Coverage Δ
unittests 56.59% <78.37%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much cleaner. added a few comments, but generally this looks good

access/grpc/grpc.go Outdated Show resolved Hide resolved
access/grpc/grpc.go Show resolved Hide resolved
access/grpc/grpc.go Outdated Show resolved Hide resolved
access/grpc/grpc.go Outdated Show resolved Hide resolved
access/grpc/grpc.go Outdated Show resolved Hide resolved
@peterargue
Copy link
Contributor

@illia-malachyn looks good. please merge master

Copy link
Contributor

@jribbink jribbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@franklywatson franklywatson merged commit cfbd2f5 into onflow:master Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify streaming endpoints code duplication
5 participants