Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend block payload with new fields #789

Conversation

illia-malachyn
Copy link
Contributor

Closes: #767

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 81.59509% with 30 lines in your changes missing coverage. Please review.

Project coverage is 57.47%. Comparing base (2f7fa8b) to head (5a42ecd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
access/grpc/convert/convert.go 74.78% 21 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #789      +/-   ##
==========================================
+ Coverage   56.59%   57.47%   +0.88%     
==========================================
  Files          35       35              
  Lines        7305     7454     +149     
==========================================
+ Hits         4134     4284     +150     
+ Misses       2670     2660      -10     
- Partials      501      510       +9     
Flag Coverage Δ
unittests 57.47% <81.59%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue
Copy link
Contributor

@illia-malachyn looks good, please merge master, then we can merge

@franklywatson franklywatson merged commit 1ba8047 into onflow:master Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BlockPayload type differs from actual block payload in protobuf schema
5 participants