Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network] Upgrade libp2p to v0.32.2 #5592

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

peterargue
Copy link
Contributor

@peterargue peterargue commented Mar 26, 2024

Closes: #5150

Backports: #5417

This PR upgrades the libp2p version to v0.32.2, other relevant dependencies included in this upgrade are:

  • github.com/libp2p/go-libp2p v0.32.2
  • github.com/libp2p/go-libp2p-kad-dht v0.25.2
  • github.com/libp2p/go-libp2p-kbucket v0.6.3
  • github.com/libp2p/go-libp2p-pubsub v0.10.0
  • github.com/multiformats/go-multiaddr v0.12.2

This is expected to address a goroutine leak related to DHT running on ANs and ENs

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.26%. Comparing base (aa98fc6) to head (163eeec).

Additional details and impacted files
@@            Coverage Diff             @@
##            v0.33    #5592      +/-   ##
==========================================
- Coverage   55.28%   55.26%   -0.03%     
==========================================
  Files        1001     1001              
  Lines       96618    96614       -4     
==========================================
- Hits        53420    53396      -24     
- Misses      39184    39203      +19     
- Partials     4014     4015       +1     
Flag Coverage Δ
unittests 55.26% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhangchiqing
Copy link
Member

Is v0.32.2 backward compatible?

When we roll out this update, upgraded node will need to talk to nodes that is still running with v0.31.x, would it cause problem?

@peterargue
Copy link
Contributor Author

Is v0.32.2 backward compatible?

When we roll out this update, upgraded node will need to talk to nodes that is still running with v0.31.x, would it cause problem?

I'm going to test this out, but it should be compatible. Yahya also confirmed

@peterargue
Copy link
Contributor Author

I tested on localnet by upgrading on node of each type. I also ran one AN on MN and TN over the weekend with no issues.

Copy link
Member

@zhangchiqing zhangchiqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, nice work!

@peterargue peterargue merged commit d8f0457 into v0.33 Apr 1, 2024
51 checks passed
@peterargue peterargue deleted the petera/upgrade-libp2p-v0.33 branch April 1, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants