Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.22 #6037

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Update to Go 1.22 #6037

merged 5 commits into from
Jun 5, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Jun 4, 2024

Go 1.20 has been unsupported since Go 1.22 got released, three months ago.

Update to Go 1.22 to get latest improvements.

See https://discord.com/channels/613813861610684416/1235013191633993749

@turbolent turbolent requested review from a team and removed request for a team June 4, 2024 22:37
@turbolent turbolent requested a review from tarakby as a code owner June 4, 2024 22:37
@turbolent turbolent requested a review from peterargue June 4, 2024 22:37
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 2.15621% with 2042 lines in your changes missing coverage. Please review.

Project coverage is 42.29%. Comparing base (4ca1a25) to head (c9417d9).

Files Patch % Lines
fvm/environment/mock/environment.go 0.00% 124 Missing and 7 partials ⚠️
access/mock/api.go 0.00% 85 Missing ⚠️
engine/access/mock/access_api_server.go 0.00% 84 Missing and 1 partial ⚠️
engine/access/mock/access_api_client.go 1.17% 80 Missing and 4 partials ⚠️
integration/benchmark/mock/client.go 1.58% 59 Missing and 3 partials ⚠️
fvm/environment/mock/accounts.go 0.00% 35 Missing ⚠️
engine/access/mock/execution_api_server.go 0.00% 26 Missing and 1 partial ⚠️
engine/access/mock/execution_api_client.go 3.70% 17 Missing and 9 partials ⚠️
engine/access/state_stream/mock/api.go 3.70% 22 Missing and 4 partials ⚠️
module/mempool/mock/back_data.go 0.00% 23 Missing ⚠️
... and 265 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6037       +/-   ##
===========================================
- Coverage   55.86%   42.29%   -13.58%     
===========================================
  Files        1133     1801      +668     
  Lines       89975   129141    +39166     
===========================================
+ Hits        50269    54616     +4347     
- Misses      34921    68747    +33826     
- Partials     4785     5778      +993     
Flag Coverage Δ
unittests 42.29% <2.15%> (-13.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent mentioned this pull request Jun 4, 2024
6 tasks
@turbolent
Copy link
Member Author

@peterargue Looks like some of the mocks in some tests (TestHandler) need to be adjusted (mock.AnythingOfType("*context.emptyCtx") should probably be just mock.Anything?)

@peterargue
Copy link
Contributor

@peterargue Looks like some of the mocks in some tests (TestHandler) need to be adjusted (mock.AnythingOfType("*context.emptyCtx") should probably be just mock.Anything?)

yea, I think the's the right way to fix

Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@turbolent turbolent added this pull request to the merge queue Jun 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 5, 2024
@turbolent turbolent added this pull request to the merge queue Jun 5, 2024
@tarakby
Copy link
Contributor

tarakby commented Jun 5, 2024

Merged via the queue into master with commit 3640d28 Jun 5, 2024
55 checks passed
@turbolent turbolent deleted the bastian/go-1.22 branch June 5, 2024 16:34
@turbolent
Copy link
Member Author

@tarakby yeah, please feel free to open a PR

@tarakby
Copy link
Contributor

tarakby commented Jun 7, 2024

I meant to include it here since it's related, but yes we can update it in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants