-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cadence 1.0 migration] Add migration to setup EVM heartbeat resource #6251
Conversation
3a96cb9
to
62208db
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6251 +/- ##
=======================================
Coverage 41.41% 41.41%
=======================================
Files 1990 1992 +2
Lines 141871 141907 +36
=======================================
+ Hits 58750 58767 +17
- Misses 77005 77024 +19
Partials 6116 6116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
the EVM contract changed
36b14bf
to
99a86b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! the only part that I don't have that much context is the util/programs.go
@ramtinms reverted the changes in |
…tion this also properly initialized the UUID
@ramtinms @janezpodhostnik PTAL: I replaced the implementation with a simple transaction. We can just make the |
Depends on #6249
When the EVM contract is updated from minimal to full contract, the
EVM.Heartbeat
resource must be set up.