[Util] Log verification progress #6834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
force-pushed
the
leo/log-verify-execution-result
branch
from
fe827a3 to
deb3491
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.37 #6834 +/- ##
==========================================
- Coverage 41.52% 41.52% -0.01%
==========================================
Files 2032 2032
Lines 181510 181519 +9
==========================================
- Hits 75381 75367 -14
- Misses 99896 99918 +22
- Partials 6233 6234 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
requested a deployment
to
Production Docker Registry
GitHub Actions
Waiting
janezpodhostnik
approved these changes
Jan 13, 2025
fxamacker
approved these changes
Jan 13, 2025
| @@ -93,9 +93,9 @@ func run(*cobra.Command, []string) { | |||
| } | |||
|
|
|||
| func parseFromTo(fromTo string) (from, to uint64, err error) { | |||
| parts := strings.Split(fromTo, "-") | |||
| parts := strings.Split(fromTo, "_") | |||
There was a problem hiding this comment.
The from_to help message and delimiter should match. Currently, the help message uses - (instead of _) in examples.
flow-go/cmd/util/cmd/verify_execution_result/cmd.go
Lines 49 to 50 in f7188ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log the progress of backward compatibility tests.