-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Make response for data providers consistent. #6846
base: master
Are you sure you want to change the base?
[Access] Make response for data providers consistent. #6846
Conversation
…The-K-R-O-K/flow-go into UlyanaAndrukhiv/6775-websocket-responses
…-events-data-provider
…The-K-R-O-K/flow-go into UlyanaAndrukhiv/6775-websocket-responses
…The-K-R-O-K/flow-go into UlyanaAndrukhiv/6775-websocket-responses
…:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6775-websocket-responses
…ed response for SendTransactionStatusesDataProvider, updated test
…github.com:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6775-websocket-responses
…xecution result from response, added payload to result
…achuk/6819-make-response-for-data-providers-consistent
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6846 +/- ##
==========================================
- Coverage 41.19% 41.02% -0.17%
==========================================
Files 2109 2079 -30
Lines 185664 182029 -3635
==========================================
- Hits 76479 74677 -1802
+ Misses 102777 101100 -1677
+ Partials 6408 6252 -156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
engine/access/rest/websockets/data_providers/account_statuses_provider.go
Outdated
Show resolved
Hide resolved
engine/access/rest/websockets/data_providers/account_statuses_provider_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have any other comments. Looks good!
engine/access/rest/websockets/data_providers/blocks_provider.go
Outdated
Show resolved
Hide resolved
…achuk/6819-make-response-for-data-providers-consistent
Closes: #6819