Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Make response for data providers consistent. #6846

Open
wants to merge 53 commits into
base: master
Choose a base branch
from

Conversation

AndriiDiachuk
Copy link
Contributor

Closes: #6819

UlyanaAndrukhiv and others added 30 commits December 9, 2024 19:11
…The-K-R-O-K/flow-go into UlyanaAndrukhiv/6775-websocket-responses
…The-K-R-O-K/flow-go into UlyanaAndrukhiv/6775-websocket-responses
…The-K-R-O-K/flow-go into UlyanaAndrukhiv/6775-websocket-responses
…:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6775-websocket-responses
…ed response for SendTransactionStatusesDataProvider, updated test
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 56.70732% with 142 lines in your changes missing coverage. Please review.

Project coverage is 41.02%. Comparing base (8ff124c) to head (e549056).

Files with missing lines Patch % Lines
...e/access/rest/common/models/mock/link_generator.go 14.37% 129 Missing and 2 partials ⚠️
engine/access/rest/router/router.go 0.00% 5 Missing ⚠️
engine/access/rest/http/routes/blocks.go 70.00% 3 Missing ⚠️
.../rest/websockets/data_providers/blocks_provider.go 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6846      +/-   ##
==========================================
- Coverage   41.19%   41.02%   -0.17%     
==========================================
  Files        2109     2079      -30     
  Lines      185664   182029    -3635     
==========================================
- Hits        76479    74677    -1802     
+ Misses     102777   101100    -1677     
+ Partials     6408     6252     -156     
Flag Coverage Δ
unittests 41.02% <56.70%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have any other comments. Looks good!

…achuk/6819-make-response-for-data-providers-consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Make response for data providers consistent with action responses
5 participants